From cc12a3603ada6dfa67bf902bf2139db52ce85625 Mon Sep 17 00:00:00 2001
From: Noah Spannbauer <noahspannbauer@icloud.com>
Date: Fri, 28 Nov 2025 11:13:25 -0600
Subject: [PATCH] adding app registration module

---
 modules/app_registration/terraform.tf |  2 +-
 modules/app_registration/variables.tf | 25 +++++++++++++++----------
 2 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/modules/app_registration/terraform.tf b/modules/app_registration/terraform.tf
index 8d26876..bb02569 100644
--- a/modules/app_registration/terraform.tf
+++ b/modules/app_registration/terraform.tf
@@ -2,7 +2,7 @@ terraform {
   required_providers {
     azuread = {
       source = "hashicorp/azuread"
-      configuration_aliases = [ entra ]
+      configuration_aliases = [ azuread.entra ]
     }
   }
 }
\ No newline at end of file
diff --git a/modules/app_registration/variables.tf b/modules/app_registration/variables.tf
index 5aee15f..6065e2b 100644
--- a/modules/app_registration/variables.tf
+++ b/modules/app_registration/variables.tf
@@ -9,21 +9,23 @@ variable "id_token_issuance_enabled" {
 }
 
 variable "additional_resource_access" {
-  type = optional(list(object({
+  default = null
+  type = list(object({
     id = string
     type = string
-  })))
+  }))
 }
 
 variable "app_roles" {
-  type = optional(list(object({
+  default = null
+  type = list(object({
     allowed_member_types = list(string)
     description = string
     display_name = string
     enabled = bool
     id = string
     value = string
-  })))
+  }))
 }
 
 variable "app_reg_name" {
@@ -50,13 +52,14 @@ variable "destination" {
 }
 
 variable "federated_identity_credential" {
-  type = optional(object({
+  default = null
+  type = object({
     display_name = string
     description = string
     audiences = list(string)
     issuer = string
     subject = string
-  }))
+  })
 }
 
 variable "enable_identifier_uri" {
@@ -65,7 +68,8 @@ variable "enable_identifier_uri" {
 }
 
 variable "oauth2_permission_scopes" {
-  type = optional(list(object({
+  default = null
+  type = list(object({
     admin_consent_description = string
     admin_consent_display_name = string
     enabled = bool
@@ -74,14 +78,15 @@ variable "oauth2_permission_scopes" {
     user_consent_description = string
     user_consent_display_name = string
     value = string
-  })))
+  }))
 }
 
 variable "secret" {
-  type = optional(object({
+  default = null
+  type = object({
     display_name = string
     end_date = optional(string)
-  }))
+  })
 }
 
 variable "redirect_uris" {