adding api unit tests (#108)

* adding api unit tests

* adding not signed in alerts to flights and logs

api/src/health/health.controller.spec.ts

@@ -1,42 +1,25 @@
-import { Test, TestingModule } from '@nestjs/testing';
-import { HealthController } from './health.controller';
-import { HealthService } from './health.service';
+import { Test, TestingModule } from "@nestjs/testing";
+import { HealthController } from "./health.controller"
+import { HttpStatus } from "@nestjs/common";
 
 describe('HealthController', () => {
-  let controller; HealthController;
-
-  const mockHealthService = {
-    isDatabaseConnected: jest.fn()
-  }
+  let controller: HealthController;
 
   beforeEach(async () => {
     const module: TestingModule = await Test.createTestingModule({
-      controllers: [HealthController],
-      providers: [HealthService]
+      controllers: [HealthController]
     }).compile();
 
     controller = module.get<HealthController>(HealthController);
   })
 
-  it('isHealthy => should return true', () => {
+  it('should be defined', () => {
     expect(controller).toBeDefined();
-  });
-
-  it('should return database connected', async () => {
-    jest.spyOn(mockHealthService, 'isDatabaseConnected').mockReturnValue(true);
-
-    const result = await controller.isHealthy();
-
-    expect(mockHealthService.isDatabaseConnected).toHaveBeenCalled();
-    expect(result).toEqual(true);
   })
 
-  it('isHealthy => should return error', async () => {
-    jest.spyOn(mockHealthService, 'isDatabaseConnected').mockReturnValue(false);
-
+  it('isHealth => should return status ok', async () => {
     const result = await controller.isHealthy();
 
-    expect(mockHealthService.isDatabaseConnected).toHaveBeenCalled();
-    expect(result).toEqual(false);
+    expect(result).toEqual(HttpStatus.OK);
   })
 })

api/src/health/health.controller.ts

@@ -1,27 +1,13 @@
 import {
   Controller,
   Get,
-  HttpException,
+  HttpStatus,
 } from '@nestjs/common';
-import { HealthService } from './health.service';
-import { CustomError } from 'src/error/customError';
-
 
 @Controller('health')
 export class HealthController {
-  constructor(
-    private readonly healthService: HealthService
-  ) {}
-
- 
   @Get()
-  async isHealthy(): Promise<boolean> {
-    try {
-      return await this.healthService.isDatabaseConnected();
-    } catch (error) {
-      const customError = error as CustomError;
-
-      throw new HttpException(customError.message, customError.statusCode);
-    }
+  async isHealthy(): Promise<HttpStatus> {
+    return HttpStatus.OK
   }
 }

api/src/health/health.module.ts

@@ -1,11 +1,7 @@
 import { Module } from '@nestjs/common';
 import { HealthController } from './health.controller';
-import { HealthService } from './health.service';
 
 @Module({
   controllers: [HealthController],
-  providers: [
-    HealthService
-  ]
 })
 export class HealthModule {}

api/src/health/health.service.spec.ts

@@ -1,14 +0,0 @@
-import { Test, TestingModule } from '@nestjs/testing';
-import { HealthService } from './health.service';
-
-describe('HealthService', () => {
-  let service: HealthService;
-
-  beforeEach(async () => {
-    const module: TestingModule = await Test.createTestingModule({
-      providers: [HealthService]
-    }).compile();
-
-    service = module.get<HealthService>(HealthService);
-  });
-});

api/src/health/health.service.ts

@@ -1,22 +0,0 @@
-import { Injectable } from '@nestjs/common';
-import { CustomError } from '../error/customError';
-import { DataSource } from 'typeorm';
-
-@Injectable()
-export class HealthService {
-  constructor(private dataSource: DataSource) {}
-
-  async isDatabaseConnected(): Promise<boolean> {
-    try {
-      const isDatabaseConnected: boolean = this.dataSource.isInitialized;
-
-      if (isDatabaseConnected) {
-        return isDatabaseConnected;
-      } else {
-        throw new CustomError('Database not connected', 'Database not connected', 400)
-      }
-    } catch (error) {
-      throw error;
-    }
-  }
-}